search

codeisscience / code-is-science

Scientific code needs to be open source and peer reviewed
http://www.codeisscience.com
MIT License
136 stars 32 forks source link

Use default templates for allcontributors #93

Closed JPTIZ closed 4 years ago

JPTIZ commented 4 years ago

As stated in https://github.com/codeisscience/code-is-science/issues/87#issuecomment-686588245, defining a stub contributorTemplate have side effects such as taking off the emojis (since they're not part of the template). Since we're not using anything specific in the template (instead, we're just using a standard minimalist example template), we can rely on the default allcontributors' template parameters to generate the default HTML with emojis back.

This is not enough to fix #87, but it is the first step. We probably will have to re-add contributors after this is merged in order for emojis to appear.

yochannah commented 4 years ago

This appears to possibly be in a perpetual merge conflict loop - merging now. We might need to check that this doesn't happen next time and possibly tweak things.