codeitcodes / codeit

Mobile code editor connected to Git.
https://codeit.codes
Other
128 stars 24 forks source link

"Connection problems" in Incognito Mode #265

Open pcb-astro opened 1 year ago

pcb-astro commented 1 year ago

Information:

Description Thanks for this cool software. I'm using it to embed a web-based visualization in my Medium blog post. Everything works fine when running in a "normal" Chrome window. However, when I switch to Incognito mode (for testing), the embed does not load and I get a message "Connection Problems? Let us know"

I get the following errors in browser console

Codeit 3.4.5. utils.js:81 
worker-channel.js:130 Uncaught (in promise) DOMException: Failed to register a ServiceWorker for scope ('https://codeit.codes/') with script ('https://codeit.codes/service-worker.js'): The user denied permission to use Service Worker.
utils.js:447 Uncaught (in promise) DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.
    at getStorage (https://codeit.codes/utils.js:447:3)
    at https://codeit.codes/git/gitauth.js:6:14

Example Blog post URL- https://humanastronomy.medium.com/hoping-that-it-works-8c140c18ed29

Cde.run URL which is being embedded - https://cde.run/pcb-astro/qm/view1_show.html (view1_show.html just creates an iframe which calls https://pcb-astro.github.io/qm/view1.html )

Medium seems to use embedly and calls this URL https://cdn.embedly.com/widgets/media.html?src=https%3A%2F%2Fcodeit.codes%2Fapi%2Flink%3Furl%3Dhttps%3A%2F%2Fcodeit.codes%2Fapi%2Flink%3Furl%3Dpcb-astro%252Fqm%252Fview1_show.html%26oembed%3Dtrue&display_name=Codeit&url=https%3A%2F%2Fcodeit.codes%2Fapi%2Flink%3Furl%3Dpcb-astro%252Fqm%252Fview1_show.html&image=https%3A%2F%2Fcodeit.codes%2Fimages%2Fbanner-og.png&key=a19fcc184b9711e1b4764040d3dc5c07&type=text%2Fhtml&schema=codeit

benhatsor commented 1 year ago

I can't reproduce the issue in Chrome Version 114.0.5735.106 (Official Build) (x86_64). I think you might have cookies disabled, which are required for Codeit to function. You can check that in your browser settings.

benhatsor commented 1 year ago

PS. Unrelated to this, you've found a bug. I was wondering why you'd embed the page view1_show.html with an iframe that links to a Github Pages-rendered file view1.html instead of just embedding the file view1.html directly. Turns out you've used Git submodules in your project, which aren't supported in Live View yet. I didn't know about these, so thanks! I've added it to the list: #266