search

codejoust / session.js

Session.js - Get user session information
Other
1.2k stars 84 forks source link

Fix IE11 detection, fix tests for IE #39

Closed itsuryev closed 10 years ago

itsuryev commented 10 years ago

session.js as it stands right now does not correctly detect IE11. It says it is Mozilla 11.

This happens because useragent has been changed significantly compared to IE10. IE10: Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; WOW64; Trident/6.0) IE11: Mozilla/5.0 (Windows NT 6.3; Trident/7.0; rv 11.0) like Gecko

With this pull request I am adding additional logic for browser check + fixing browser detection tests for IE (please tell if it would be useful to fix other tests similar way).

itsuryev commented 10 years ago

I humbly summon you, @codejoust, in this thread! some magical passes ensures

victor-homyakov commented 10 years ago

+1 to fix this issue

codejoust commented 10 years ago

Sorry for the silence and having this fall through the cracks.