search

codekitchen / dinghy-http-proxy

the http proxy container that dinghy uses
MIT License
125 stars 43 forks source link

increase proxy_buffers and proxy_buffer_size #36

Closed djbender closed 7 years ago

djbender commented 7 years ago

This change will increase the size of proxy_buffers and proxy_buffer_size so that longer URLs don't return a 502 Bad Gateway.

codekitchen commented 7 years ago

"longer URLs don't return a 502 Bad Gateway" sounds like a problem with too-large request headers, but according to the docs both these parameters you've tweaked are related to the response from the upstream server, not the request, so I think I'm misunderstanding what you mean. Do you have an example of what this fixes?

I ask because there was already an attempt to fix what sounds like the same issue here: https://github.com/codekitchen/dinghy-http-proxy/pull/9

djbender commented 7 years ago

@codekitchen this fixes a situation in which the upstream sever is able to process the request, but the proxy can't handle the response headers as they are now too large (which appears to be a symptom along with urls that are of a certain length) resulting in the upstream server returning a 200 but dinghy-http-proxy returning a bad gateway 502.

I can find the specific error in the logs if that would be helpful?

Also the gradebook team at Instructure says hi 👋 😄

codekitchen commented 7 years ago

Ah OK, so it's correlated with a long request URL but not directly caused by it -- probably caused by the pagination header in the response or something similar. Thanks for the info, looks good to me.

Also haaaiii I miss u all. 🤗