search

codekitchen / dinghy

faster, friendlier Docker on OS X
MIT License
2.12k stars 109 forks source link

`dinghy start` overrides `:proxy_disabled` preferences #261

Closed charlesfleche closed 6 years ago

charlesfleche commented 6 years ago

We are running dinghy with xhyve and deactivate the proxy to bind an nginx server directly to the port 80. Our preferences.yml looks like that:

---
:preferences:
  :proxy_disabled: true
  :fsevents_disabled: false
  :create:
    provider: xhyve
    memory: 1024
    cpus: 1
  :unfs_disabled: false
  :dns_disabled: false

However after a dinghy up the proxy_disabled setting is reset to false. So the first dinghy up will have the proxy turned off, but the second dinghy up will keep the proxy running, breaking our dev environment.

codekitchen commented 6 years ago

Hm yeah the logic got changed and is definitely wrong now. I've changed it back and pushed a new v4.6.1 release, so an update should get you fixed up.

Note that if you leave DNS enabled the http_proxy container will still be run, since it runs the DNS service too, it just won't bind to ports 80/443. I should probably rename the container or run two separate containers.