search

codekoala / pass-qr

A pass extension that lets you quickly generate a QR code for passwords using fzf or rofi
https://www.passwordstore.org
GNU General Public License v3.0
6 stars 4 forks source link

Annoying Limitations #1

Open xeruf opened 2 years ago

xeruf commented 2 years ago

Thanks for the tool! I have some feedback from first experiments:

Just running pass qr exits unsuccessfully, even though I have fzf installed.

pass qr -f works, but it would be nice to be able to display the qr code in other ways rather than a popup window.

Also, runninf pass qr my/password/path should simply use the given path.

codekoala commented 2 years ago

Hi @xeruf thanks for the feedback! I should be able to look into this a bit later today or tomorrow.

codekoala commented 2 years ago

Oh look at that, it's been 2 weeks already. My apologies. Way too many things going on.

@xeruf how did you install fzf on your system? Was it via your system's package manager? Via its install script? Basically, I'm curious to see where the binary resides, and whether that location is in your $PATH when you are running pass qr without the -f. I expect it will be on your $PATH since the -f flag does work. Just trying to understand the situation.

Also, do you have rofi installed on your system?

codekoala commented 2 years ago

@xeruf I have pushed up some changes to hopefully address your feedback. You should be able to add export PASS_QR_FZF=1 to your ~/.bashrc (or similar for whatever shell you use) in order to have pass qr implicitly use fzf. Additionally, you should now be able to save the QR codes to disk rather than immediately displaying them.

I'm closing this for now, but please do feel free to re-open if the problems persist after you update to v0.2.0!

xeruf commented 2 years ago

rofi is not installed, fzf via Arch system package - support of fzy could also be interesting, or generally an environment variable to choose the fuzzy finder. Maybe that should actually become standard to have a FUZZER or however one could call it next to the PAGER environment variable.

Anyways, on 0.2.0 pass qr still fails silently when I add no flags, while pass clip does not have that issue.

codekoala commented 2 years ago

Thank you for the additional information! I haven't used fzy before, but I can certainly look into adding support for that.

or generally an environment variable to choose the fuzzy finder

To be clear, did you set PASS_QR_FZF=1 when pass qr failed after updating to 0.2.0?

xeruf commented 2 years ago

yes that works, but shouldn't be necessary - and I would prefer one generic environment variable to set the fuzzy finder

codekoala commented 2 years ago

If you are aware of an emerging standard variable name (I can't say I've seen FUZZER referenced previously, but I haven't gone looking either) to select the fuzzy finder, I can certainly implement that too. I will continue to look into why it works for pass clip but not this too.