Closed larsk2009 closed 1 year ago
Base: 84.14% // Head: 77.61% // Decreases project coverage by -6.53%
:warning:
Coverage data is based on head (
4594806
) compared to base (4cd78f9
). Patch coverage: 87.58% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Okay, I'll remove that commit
Fixes #12.
I updated the unit tests to use the defaults where possible (not possible for arrays, as you get empty arrays). Maybe you don't want this as you might want all options to be
Some
where default will make themNone
. If so, I can remove #30848bc from this PR.I also noticed one bug after using the default types in the unit tests. The status notification timestamp was missing a
skip_serializing_if
for the option type. That is also fixed in this PR.