search

codelight-eu / gdpr-framework

The easiest way to make your WordPress site GDPR-compliant
Other
24 stars 7 forks source link

Consider moving core framework to a composer package #2

Open Shelob9 opened 6 years ago

Shelob9 commented 6 years ago

I was about to experiment with this framework, to see if it worked for Caldera Forms as I thought it was a framework, not a plugin. I'd develop an add-on that used this framework, if I could control dependency management. If my plugin requires another plugin, I don't control the dependency and it's a complicated UI.

indrek-k commented 6 years ago

I see what you mean! However, wouldn't this open up a whole new set of problems if multiple plugins have the same requirement?

We just published beta versions of add-ons for Gravity Forms and Formidable Forms over the weekend. They both require the framework to function properly. If we moved the core to a composer package, how would you solve the conflict? Maybe there is a good way to do this, but as far as i know it's an unsolved problem.

As an alternative, I propose we develop a simple re-usable system for displaying admin notices and not executing any code if the core framework is missing or there's a version conflict.

But I'm all ears if you have better ideas!