search

codeliner / php-ddd-cargo-sample

PHP 7 Version of the cargo sample used in Eric Evans DDD book
http://codeliner.github.io/php-ddd-cargo-sample/
BSD 3-Clause "New" or "Revised" License
796 stars 151 forks source link

Docker usage instructions #48

Closed tomhaj closed 6 years ago

tomhaj commented 6 years ago

Proposal how to use docker to run cargo app

tomhaj commented 6 years ago

@codeliner its fixed.

Take a look https://github.com/codeliner/php-ddd-cargo-sample/pull/48/commits/040b2e7707941082527c2beb43ee70f87cc9caf8#diff-8f913077a8342cf43a8dfa290e89df3bR12

tomhaj commented 6 years ago

@codeliner @sandrokeil so what with this pull request. Should we merge it?

sandrokeil commented 6 years ago

@codeliner LGTM

codeliner commented 6 years ago

thx @tomhaj for the work and @sandrokeil for review :+1: