Libray downgrading in installation

codelucas / newspaper

newspaper3k is a news, full-text, and article metadata extraction in Python 3. Advanced docs:

https://goo.gl/VX41yK

MIT License

14.15k stars 2.12k forks source link

Libray downgrading in installation #138

Closed erickrf closed 8 years ago

erickrf commented 9 years ago

I just installed newspaper via pip and noticed it downgraded some previously installed libraries:

nltk went from 3.0.2 to 2.0.5.
lxml went from 3.4.1 to 3.3.5
requests went from 3.5.0 to 3.3.0
six went from 1.8.0 to 1.7.3

This is weird. I don't think newspaper has any dependency specific to these older versions, does it?

yprez commented 9 years ago

The requirements.text files states the specific versions: https://github.com/codelucas/newspaper/blob/master/requirements.txt I think that it would be much better if the requirements would list the minimal compatible versions, something like:

requests >= 3.2
nltk >= 3.0.0
# ...

@codelucas what do you think? I could make a PR for it if it's ok with you...

glesica commented 9 years ago

+1 The more immediate problem, though, is that the version in PyPi is (0.0.9.8). The latest version in the repo at least uses more current versions of nltk and requests (but still pins them exactly, which is a mistake IMHO).

Edit: Oops, I am switching from Python 2 to 3 and didn't notice I had to change to newspaper3k. Comments about the version pinning still stand.