codemagic-ci-cd / cli-tools

Various utilities to managing Android and iOS app builds, code signing, and deployment.
https://codemagic.io/start/
GNU General Public License v3.0
261 stars 42 forks source link

Action get-latest-testflight-build-number returns version number instead of build number #303

Closed jtruenary closed 1 year ago

jtruenary commented 1 year ago

Since the last release v0.36.7, the action get-latest-testflight-build-number returns version number instead of build number. Our Codemagic CI pipelines are breaking because of this. Any suggestions?

priitlatt commented 1 year ago

Hi @jtruenary, thank you for your report. If anything, then version 0.36.6 is to blame for it as it includes changes from PR #300, that altered the behaviour of app-store-connect get-latest-testflight-build-number (and similar actions).

Could you please provide some more context of your use-case with terminal output and screenshots from the related application TestFlight builds?

mazzonem commented 1 year ago

I'm having exactly the same issue.

It is generally believed that BuildNumber always goes up but Apple allows reusing (lower build number) when changing the app version. So Overall #300 is correct and we should adapt our CI pipelines @jtruenary. https://developer.apple.com/library/archive/technotes/tn2420/_index.html#//apple_ref/doc/uid/DTS40016603-CH1-VERSION_NUMBER_AND_BUILD_NUMBER_CHECKLIST

I hope it helps the next person looking for this 👍

jtruenary commented 1 year ago

@priitlatt Yes you are right. Our last build was on 0.36.5 before this failing build, so our pipelines never ran on 0.36.6.

We run this command:

app-store-connect get-latest-testflight-build-number "$APP_STORE_ID"

This is the output:

Found build number 1.18.35.104.6 from TestFlight version 6

Previously we were fetching the build number and incrementing it in our build job.

priitlatt commented 1 year ago

@jtruenary could you please provide a screenshot of what is going on in your TestFlight?

priitlatt commented 1 year ago

Closing due to inactivity.