codemagic-ci-cd / cli-tools

Various utilities to managing Android and iOS app builds, code signing, and deployment.
https://codemagic.io/start/
GNU General Public License v3.0
235 stars 39 forks source link

Provisioning profile creation error handling #377

Closed priitlatt closed 7 months ago

priitlatt commented 7 months ago

Provisioning profiles can be created using action app-store-connect create-profile, or as a side-effect when running app-store-connect fetch-signing-files with --create option. There were couple of issues linked to the devices that are included in the created profile.

  1. All development and ad-hoc profiles require devices and cannot be created without any device relationships. Otherwise App Store Connect API returns an error response. Hence there is a validation in API client method which raises a ValueError in case devices are missing but requried. This error was not handled on caller side however, and hence actions that created profiles failed unexpectedly.
  2. Action app-store-connect create-profile had --device-ids as a required argument, which is not correct as release profiles are not expected to contain any devices and as such user should not specify any device IDs when creating such provisioning porfiles.

Due to the changes in this PR:

Updated actions: