search

codemagic-ci-cd / cli-tools

Various utilities to managing Android and iOS app builds, code signing, and deployment.
https://codemagic.io/start/
GNU General Public License v3.0
267 stars 42 forks source link

Need to remove the deprecated `idfaDeclarations` field from `Relationships` #404

Closed powdream closed 5 months ago

powdream commented 5 months ago

Apple seems to have deleted an old field idfaDeclaration from their response in the end. However, because the field is still alive in the codemagic-tools python lib, the following error happens.

  File "/home/runner/.local/lib/python3.9/site-packages/codemagic/apple/app_store_connect/apps/apps.py", line 125, in list_app_store_versions
    return [AppStoreVersion(app_store_version) for app_store_version in app_store_versions_data]
  File "/home/runner/.local/lib/python3.9/site-packages/codemagic/apple/app_store_connect/apps/apps.py", line 125, in <listcomp>
    return [AppStoreVersion(app_store_version) for app_store_version in app_store_versions_data]
  File "/home/runner/.local/lib/python3.9/site-packages/codemagic/apple/resources/resource.py", line 253, in __init__
    self.relationships = self._create_relationships(api_response)
  File "/home/runner/.local/lib/python3.9/site-packages/codemagic/apple/resources/resource.py", line 245, in _create_relationships
    return cls.Relationships(**defined_fields)
TypeError: __init__() missing 1 required positional argument: 'idfaDeclaration'

The version current we are using is

codemagic-cli-tools==0.51.0
priitlatt commented 5 months ago

@powdream thank you for reporting this. We've removed the deprecated field reference and app-store-connect actions work as expected again with new version 0.51.1.

priitlatt commented 5 months ago

https://github.com/codemagic-ci-cd/cli-tools/issues/404#issuecomment-2133052739 CC @geerpm & @nikocm

powdream commented 5 months ago

@priitlatt Thanks a lot for your support