codemagic-ci-cd / cli-tools

Various utilities to managing Android and iOS app builds, code signing, and deployment.
https://codemagic.io/start/
GNU General Public License v3.0
267 stars 42 forks source link

Fix `ProvisioningProfile.team_identifier` type interface #440

Closed priitlatt closed 1 day ago

priitlatt commented 1 day ago

There are provisioning profiles which do not have a TeamIdentifier key in their plist. Currently ProvisioningProfile.team_identifier property returns None in this case, which is conflicting with the type signature of this property. That can cause third party usages to fail that expect that the value of this property is always str. As with missing team name, default to empty string instead of None in case of missing value.

Note that is doesn't seem to be possible to generate such profiles any more and those are just remnants from past.