iffyuva
commented
9 years ago @CUnknown thanks for this bug report. I will get back to you on this.
Closed OtherCroissant closed 9 years ago
iffyuva
commented
9 years ago @CUnknown thanks for this bug report. I will get back to you on this.
iffyuva
commented
9 years ago looks like this issue is not entirely related to this gem. @CUnknown can you post code showing how you inherited from Invoice model, and the code in CrudController#build_member ?
OtherCroissant
commented
9 years ago Thanks for your reply! The invoice classes are looking like this:
class Invoice < InvoicingLedgerItem
acts_as_invoice
end
class ClientInvoice < Invoice
belongs_to :organisation
belongs_to :recipient, class_name: 'Client'
belongs_to :author, class_name: 'User'
end
CrudController#build_member is looking like:
collection.build(member_params)where member_params are the fetched permitted parameters and the collection is organisation.client_invoices
My Organisation model (and my Client model) has a has_many relation:
has_many :client_invoices, dependent: :destroyI Found something interesting here. When I open the rails console and perform ClientInvoices.all, I get the empty set [], which is correct. When I perform Organisation.find(1).client_invoices I get the following:
[6] pry(main)> Organisation.find(1).client_invoices
Organisation Load (1.1ms) SELECT "organisations".* FROM "organisations" WHERE "organisations"."id" = $1 LIMIT 1 [["id", 1]]
PG::UndefinedColumn: ERROR: column invoicing_ledger_items.organisation_id does not exist
LINE 1: ...ing_ledger_items"."type" IN ('ClientInvoice') AND "invoicing...
^
: SELECT "invoicing_ledger_items".* FROM "invoicing_ledger_items" WHERE "invoicing_ledger_items"."type" IN ('ClientInvoice') AND "invoicing_ledger_items"."organisation_id" = $1
=> #<ClientInvoice::ActiveRecord_Associations_CollectionProxy:0x48dc5bc>Which is weird, because it looks for the column organisation_id in the invoicing_ledger_items table, and not in the client_invoices table (which has those references).
Kind Regards,
Christiaan
iffyuva
commented
9 years ago oh okie. so you dont have proper foreign key associations, try this:
class Organisation < AR::Base
has_many :client_invoices, dependent: :destroy, foreign_key: :sender_id
end@CUnknown can you check with this code?
OtherCroissant
commented
9 years ago It looks like I got it working. I was creating a model which handled the relations with the sender and the receiver myself, but your gem already stores these references.
I also had a question about the functionality. I want to create a invoice controller where the user can add invoice items on the fly (with a nested forms construction). Do you think that this is possible? Another feature that I would like to have is the ability to save concept invoices. In your instructions, you mention that the invoices are immuatable, which is the desired behaviour when the created invoice has an invoice number attached to it. (Our tax authorities require the invoice numbering to be complete, so no invoice number may be missing from the administration). But if we want to be able to create concept invoices, these should not get an invoice number and those should not be immutable yet. Is it possible to create such a system with your gem?
iffyuva
commented
9 years ago ability to create invoices on the fly is possible. please open a new issue and explain what is required. 'invoices are immutable' is not entirely true. its afterall bunch of entries in database, and you can always change them, you have to write more code.
Hi,
I followed the steps that you suggested http://invoicing.codemancers.com/, but unfortunately I cannot get it working. Once I want to build an object that inherits the Invoice model, I get the following error: undefined method `val' for #Arel::Nodes::BindParam:0x0000000625ef08
I'm using Rails 4.2 and the stack trace is as follows:
Could you point me in the right direction?