codemancers / invoicing

Ruby invoicing framework gem
http://invoicing.c9s.dev/
MIT License
265 stars 40 forks source link

UUID based PK are not supported #60

Open etcook opened 6 years ago

etcook commented 6 years ago

One issue for us is the assumption of serial IDs. We have already implemented UUIDs as a primary key for all of our models, but many of the underlying methods normalize against the integer assumption. This makes things like account_summary, break.

Before I work on a PR, I'd like to discuss how you'd like to handle these. Would you like to conditionally test for UUIDs and then continue to normalize for integers or would you like to just sanitize and allow both?

I'd also like to explore replicating things like polymorphic accessors, to make the objects behave more "Active Record-like."

The foundational structure is working well. Thanks for your work on this.