search

codemancers / invoicing

Ruby invoicing framework gem
http://invoicing.c9s.dev/
MIT License
265 stars 40 forks source link

Fix currency_value_class_info error #75

Closed thegeorgeous closed 4 years ago

thegeorgeous commented 4 years ago

Fixes #66

Originally the method was passed as a string to the if condition. This is equivalent to passing the method itself rather than using the result of the method call in the if condition.

When adding support for Rails 5, the string was replaced with the method call which caused the bug. This has been replace with a lambda which represents the method itself rather than the result of the method being called.

Oldharlem commented 4 years ago

can this be merged? running of the pr branch now. Works but not indefinately

ezr-ondrej commented 10 months ago

Can we release this :pray: I don't love to get gems from git :(