search

codemancers / invoicing

Ruby invoicing framework gem
http://invoicing.c9s.dev/
MIT License
265 stars 40 forks source link

Fix issues due to changes in `sanitize_sql` in ActiveRecord #76

Closed thegeorgeous closed 4 years ago

thegeorgeous commented 4 years ago

sanitize_sql no longer accepts hashes in Rails > 5

Fixes #71

weber-s commented 4 years ago

Hello!

Any news for this PR? Since the current packaged gem (1.1.1) has error, it would be realy nice to have this merge and release :)

sreecodeslayer commented 4 years ago

@thegeorgeous Changes looks good to me 🙂 Should we be concerned about the numerous errors(not failures) in test?

thegeorgeous commented 4 years ago

@sreecodeslayer the errors are all related to changes in Rails 5. We will fix it in another PR.

sreecodeslayer commented 4 years ago

@sreecodeslayer the errors are all related to changes in Rails 5. We will fix it in another PR.

Ah got it, makes sense. approving this one in that case 👍