TimeDependent belongs_to replaced_by association should be optional for rails5.2

codemancers / invoicing

Ruby invoicing framework gem

http://invoicing.c9s.dev/

MIT License

265 stars 40 forks source link

Open weber-s opened 4 years ago

weber-s commented 4 years ago

With the rails 5 update, belongs_to association are require by default.

When trying to upgrade a rails 4 to rails 5 app with invoicing, InvoicingTaxRate failed due to this issue.

I think this PR fix it.

It should also fix #58

weber-s commented 4 years ago

I don't fully understand why the test are failling for only 2 Gemfiles. Is it specific to this PR (i.e. did I introduce a bug) or already present ?

weber-s commented 3 years ago

The merge of the other PR #80 fix the travis CI. Is it possible to merge it upstream and release it on rubygems?