search

codemancers / invoker

An awesome utility to manage all your processes in development environment
http://invoker.c9s.dev/
MIT License
460 stars 59 forks source link

Support dns aliases #203

Closed bhenderson closed 6 years ago

bhenderson commented 7 years ago

Adds support for domain alias lookup. Fixes #202 Config now accepts a new directive: alias Multiple aliases can be separated by a comma Special characters are: *: Will match one subpath **: Will match any subpaths

Let me know what you think.

thanks,

gnufied commented 7 years ago

Thank you for the PR. I will merge this shortly. I am just brooding over the way this is exposed in ini files and if there can be a better way.

gnufied commented 6 years ago

I am not sure about allowing wildcard implementation that allows "*" and enables user to take over a unrelated domain. It depends on order of processing and can be somewhat unpredictable.

May be we should consider disallowing "*" wildcard.

bhenderson commented 6 years ago

thanks @gnufied for looking at it. I've lost interest in this feature (changed jobs) so feel free to close.

thanks,

gnufied commented 6 years ago

@bhenderson thanks for opening the PR. Apologies about rather delayed review cycle. :(