search

codemancers / invoker

An awesome utility to manage all your processes in development environment
http://invoker.c9s.dev/
MIT License
460 stars 59 forks source link

Case-insensitive Host check in the Balancer #241

Closed ProGM closed 3 years ago

ProGM commented 3 years ago

Some http clients use to send the Host header in lowercase, like host: mydomain.test, and this breaks the invoker proxy.

It made me some troubles with both Cypress (who sends host header lower case), and BrowserSync proxy (same).

Since it looks like lowercase headers are acceptable, I've made a small change to make it work.

I've also added a couple of specs.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.02%) to 73.095% when pulling 2209966d4e15ea11f0eab390249101715b73978c on monade:allow-host-header-downcase into 9b93b44bcbc13914ac64c847d8249eb416a016b6 on code-mancers:master.

ProGM commented 3 years ago

@swrobel Thank you for accepting my PR!

Do you have any plan to release this any soon? Thanks!

swrobel commented 3 years ago

@ProGM working on getting it released. Thanks for your patience!