search

codemancers / invoker

An awesome utility to manage all your processes in development environment
http://invoker.c9s.dev/
MIT License
458 stars 58 forks source link

Make compliant for Ruby 3.x #250

Closed jbrodie closed 5 months ago

jbrodie commented 6 months ago

Updated http-parser-lite gem to Ruby 3.3 compliant gem. Removed deprecations / errors around the removal of exists? in Ruby 3.2 Closes #249 Closes #242

jbrodie commented 5 months ago

@iffyuva

Can someone please review this? I would love to get a new version of the gem cut and available to work on Ruby 3.x

iffyuva commented 5 months ago

@jbrodie thanks for the PR.

@swrobel would you like to cut a new release? Thanks

swrobel commented 5 months ago

Since Travis is gone and there doesn't seem to be any CI running currently, I can't tell if this is failing in any configurations. @jbrodie do you have any idea if we need to set a minimum required_ruby_version along with this change? Also, can you please add a CHANGELOG entry?

jbrodie commented 5 months ago

@swrobel I have used it on > Ruby 3.x only at this point. I can't say I have anything else below that to test it against, and I think anything below 3.x is out of support anyways. 3.0 is on the way out, 3.1 will be minimum. I would think leaving it restricted to 3.0 would be fine as I can vouch for that working.

https://www.ruby-lang.org/en/downloads/branches/

jbrodie commented 5 months ago

@swrobel I have added the gemspec ruby restriction, as well as changelog record. Also, bumped to 2.0.0 version as this is something of a major change and it just felt like the right thing to do.

swrobel commented 5 months ago

would you like to cut a new release?

@iffyuva I don't believe I have rubygems permission, so someone from your org will have to release the gem, but it should be good to go

jbrodie commented 5 months ago

@swrobel @iffyuva

Any update on when to expect this to be release on rubygems?

jbrodie commented 4 months ago

@swrobel @iffyuva

Hey guys, I don't mean to pester but any chance we can get this new version on Rubygems?

iffyuva commented 4 months ago

@jbrodie I have cut a new release. Thanks for the PR. Cheers 👍

jbrodie commented 4 months ago

Awesome. TY.