codemancers / rapidfire

Making dynamic surveys should be easy!
https://rapidfire.fly.dev/
MIT License
320 stars 141 forks source link

answers_delimiter = "\r\n" #137

Open john-huang-121 opened 5 years ago

john-huang-121 commented 5 years ago

Hello!

I am a somewhat new rails programmer and just found your gem. Since the gem surveyor does not work for me and is way too old, I decided to play around with it. While playing around with checkboxes, I ran into this problem.

Answer text is invalid (when the no checkbox in a yes/no question is checked and saved)

I narrowed it down to answer_text: "{\"0\"=>\"0\", \"1\"=>\"no\"}" and the issue being answers_delimiter not breaking up the submission correctly. When I changed "\r\n" to "\"" in the checkbox.rb model inside validate_answer it still doesn't work.

      def validate_answer(answer)
        super(answer)

        if rules[:presence] == "1" || answer.answer_text.present?
          answer.answer_text.split("\"").each do |value|
            answer.errors.add(:answer_text, :invalid) unless options.include?(value)
          end
        end
      end

Is there a way to fix this?

john-huang-121 commented 5 years ago
answer_text: "{\"0\"=>\"0\", \"1\"=>\"no\"}"
stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs for another 14 days. Thank you for your contributions.

bibstha commented 4 months ago

Just wanted to leave a comment that "\r\n" is not a default behaviour on all browsers. On Mac, pressing enter will save only "|n" for example.