search

codemancers / rapidfire

Making dynamic surveys should be easy!
https://rapidfire.fly.dev/
MIT License
319 stars 141 forks source link

Fix sqlite related travis issue & remove unsupported ruby-rails versions #141

Closed snkshukla closed 5 years ago

snkshukla commented 5 years ago

For rails versions less than 5.2, ActiveRecord needs the sqlite3 version 1.3.6 internally but the version installed with bundle is 1.4.1 due to which migration fails in specs. So hardcode sqlite3 versions to 1.3.6 in rails < 5.2 with this PR. You can find more details about the issue here

Also, ruby versions less than 2.4 and rails versions less than 4.2. are no more officially supported, so remove those versions from travis matrix as we don't need to support those versions anymore.

There is one more fix where the AddAfterSurveyContentToSurvey migration's base class was hardcoded to have [5] at the end, keeping it dynamic will fix issues as that is not supported in prior versions

akshaysasidrn commented 5 years ago

@snkshukla PR looks good to me. Might as well update the readme to remove Rails 3 support.