search

codemancers / rapidfire

Making dynamic surveys should be easy!
https://rapidfire.fly.dev/
MIT License
320 stars 141 forks source link

update question groups to surveys #73

Closed chukitow closed 8 years ago

chukitow commented 8 years ago

I was reviewing the project and I found that you were looking rename question groups to surveys so I did it :)

iffyuva commented 8 years ago

@chukitow thanks for the PR. please take a look at ci failures?

chukitow commented 8 years ago

All the build needs to be green ? cuz it only fails on 2.0.0. 2.1.10 & 2.3.1 @iffyuva

iffyuva commented 8 years ago

@chukitow for now we require all builds to be green, since builds are already green on master

chukitow commented 8 years ago

ok, I'll research why it is failing in those builds.

chukitow commented 8 years ago

@iffyuva done, all the builds are green now :)

iffyuva commented 8 years ago

thanks @chukitow will review this after office hours today 👍

iffyuva commented 8 years ago

@chukitow merged :). Thanks. i was also thinking of renaming answer_groups to attempts. would you like to take it up?

chukitow commented 8 years ago

Perfect, if I can I'll spend part of my free time renaming answer_groups :)