codemaniac-sahil / currency_converter_react

https://currency-converter-web-app.netlify.app/
MIT License
5 stars 19 forks source link

Apply basic styling #11

Open snehafarkya opened 1 year ago

snehafarkya commented 1 year ago

I can apply basic css to this project like background, colors, etc. May I?

codemaniac-sahil commented 1 year ago

Yes you can @snehafarkya

snehafarkya commented 1 year ago

I have done these changes. Check this out before merging a pull request. 2022-10-02 (6)

codemaniac-sahil commented 1 year ago

It will be great if you change something in background like change color add an image. That will beautify it.

Jaspreet099 commented 1 year ago

Hey, @codemaniac-sahil I have designed this UI, if someone wants to implement I will share its CSS.

CC design

codemaniac-sahil commented 1 year ago

@Jaspreet099 share the css with @snehafarkya or if you want to add CSS on this, you are good to go.

snehafarkya commented 1 year ago

I would like to take this.

codemaniac-sahil commented 1 year ago

@Jaspreet099 would you please share you CSS with @snehafarkya

rajdip-b commented 1 year ago

@codemaniac-sahil do I convert the UX as displayed in the picture?

rajdip-b commented 1 year ago

Hey, @codemaniac-sahil I have designed this UI, if someone wants to implement I will share its CSS.

CC design

Hey! Can you share the font name with me?

codemaniac-sahil commented 1 year ago

@Jaspreet099 are you working on this otherwise I am closing this issue.

Jaspreet099 commented 1 year ago

@codemaniac-sahil assign this issue to @snehafarkya because she already worked on a previous commit

CSS

Font used

CurrencyConverter - Sf mono- heavy (54px) Today's Price - poppins - medium (46px) One USD = 81.5183 INR - Sf mono - regular (36px) convert -poppins- semibold (54px) USD to Inr - SF mono - medium (28px)

colors

background: #0E0E11; gradient:- background: linear-gradient(90.02deg, #F6C7FF -0.76%, #8793F3 50.66%, #BBD8EF 101.02%); white text - color: #F7F9F8;

border: 5px solid #282836; border-radius: 15px;

color in USD to INR box

background: rgba(40, 40, 54, 0.6); border-radius: 15px;

codemaniac-sahil commented 1 year ago

@rajdip-b would you please change

rajdip-b commented 1 year ago

I'll update the code as soon as I can.

Jaspreet099 commented 1 year ago

@codemaniac-sahil can my design be contributed to hacktoberfest PR?

codemaniac-sahil commented 1 year ago

@Jaspreet099 no, for that you have to make PR

codemaniac-sahil commented 1 year ago

I am assigning this case to you

codemaniac-sahil commented 1 year ago

Make your own PR

codemaniac-sahil commented 1 year ago

I will accept your PR as your design is excellent.

codemaniac-sahil commented 1 year ago

@Jaspreet099 are you sending PR?

Jaspreet099 commented 1 year ago

@codemaniac-sahil where i have to send PR? Can i add my UI design image in MD file?

codemaniac-sahil commented 1 year ago

@Jaspreet099 connect with me on discord, their I will tell you how to send PR. my username is codemaniac_sahil#3664

codemaniac-sahil commented 1 year ago

Anyone wants to add something in the this project.