search

codemaniac-sahil / currency_converter_react

https://currency-converter-web-app.netlify.app/
MIT License
5 stars 19 forks source link

The amount is not formatted correctly #14

Closed subhashis2204 closed 2 years ago

subhashis2204 commented 2 years ago

Objective

The converted amount should be rounded off to 2 decimal places for better understanding.

AwsYaseen22 commented 2 years ago

Sorry @subhashis2204 I didn’t realize that; it was my first contribution and that is a good lesson to take; sorry again.

On 2 Oct 2022, at 10:43 PM, Subhashis Paul @.***> wrote:

@AwsYaseen22 https://github.com/AwsYaseen22 I was working on this issue. You should have reported it before working on it.

— Reply to this email directly, view it on GitHub https://github.com/codemaniac-sahil/currency_converter_react/issues/14#issuecomment-1264718375, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXG2GNDGKZROFCGZGIEDJYLWBHQXZANCNFSM6AAAAAAQ26WBTI. You are receiving this because you were mentioned.

Nishith-Savla commented 2 years ago

Hi @codemaniac-sahil, there is still a minute improvement that can be done in this. The code merged doesn't work for values like 1.005 and gives 1 instead of 1.01.

Assign this to me, so I can fix this by adding Epsilon to the original number.

codemaniac-sahil commented 2 years ago

Yeah, I find this bug as well. @Nishith-Savla, you are good to go.