search

codemaniac-sahil / currency_converter_react

https://currency-converter-web-app.netlify.app/
MIT License
5 stars 19 forks source link

Use a better (free) exchange rates API as the current one has only 150k requests per month #26

Closed Nishith-Savla closed 2 years ago

Nishith-Savla commented 2 years ago

The current exchange rates API only offers 150k requests per month but there is one API: exchangerate.host which doesn't have any such limit.

So I would suggest that migrating to this API would be beneficial as the project becomes popular.

I would be happy to work on this.

codemaniac-sahil commented 2 years ago

Yes please do this as soon as possible

Nishith-Savla commented 2 years ago

Sure :+1:

codemaniac-sahil commented 2 years ago

actually it is happening because in api request there is undefined variable and i am fixing it

Nishith-Savla commented 2 years ago

Ohhk

Nishith-Savla commented 2 years ago

You do that for now. I'll understand the current API response first and then replace it with the new API https://exchangerate.host

codemaniac-sahil commented 2 years ago

you are good to go @Nishith-Savla

codemaniac-sahil commented 2 years ago

@Nishith-Savla are you working on this?

Nishith-Savla commented 2 years ago

Yes, it will submit a PR today itself