codemaniac-sahil / currency_converter_react

https://currency-converter-web-app.netlify.app/
MIT License
5 stars 19 forks source link

Added country flag [fixes #6] #7

Closed najeebkp closed 2 years ago

najeebkp commented 2 years ago

Added country flag [fixes #6]

Added country flag into the currency selector.

netlify[bot] commented 2 years ago

Deploy Preview for luxury-mandazi-3bc9ef ready!

Name Link
Latest commit 582a2afc547e4f0e9da79012ad339575145ea3f7
Latest deploy log https://app.netlify.com/sites/luxury-mandazi-3bc9ef/deploys/63396bfa15de03000ae9fbd7
Deploy Preview https://deploy-preview-7--luxury-mandazi-3bc9ef.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codemaniac-sahil commented 2 years ago

Screenshot (24) It is not showing flags of country

najeebkp commented 2 years ago

Screenshot from 2022-10-02 16-21-27

Its showing fine !

codemaniac-sahil commented 2 years ago

But why it is not showing on my side.

codemaniac-sahil commented 2 years ago

Screenshot (25) It does not able to fetch the flag

najeebkp commented 2 years ago

can you hard refresh ? which browser are you using?

codemaniac-sahil commented 2 years ago

Google chrome

najeebkp commented 2 years ago

No need to fetch any flags from outside. its a separate component -( hard coded)

codemaniac-sahil commented 2 years ago

No need to fetch any flags from outside. its a separate component -( hard coded)

okay but why it is not working from my side

codemaniac-sahil commented 2 years ago

Screenshot (26) It is not working on brave browser either

najeebkp commented 2 years ago

No Idea. Check with other operating systems.

codemaniac-sahil commented 2 years ago

It will be good if you use api for fetching the countries flag

codemaniac-sahil commented 2 years ago

Screenshot (27) It only showing KID's flag

najeebkp commented 2 years ago

Its windows issue. they are not supporting flags emojis. https://answers.microsoft.com/en-us/windows/forum/all/flag-emoji/85b163bc-786a-4918-9042-763ccf4b6c05?page=1

codemaniac-sahil commented 2 years ago

Please fix this

codemaniac-sahil commented 2 years ago

Try to use API

najeebkp commented 2 years ago

Let me check !

najeebkp commented 2 years ago

I'm sorry brother. i couldn't find a solution.

codemaniac-sahil commented 2 years ago

Don't worry, it happens

codemaniac-sahil commented 2 years ago

@najeebkp you can use this api to fetch country flag https://ipapi.com/documentation