search

codemanki / cloudscraper

--DEPRECATED -- 🛑 🛑 Node.js library to bypass cloudflare's anti-ddos page
MIT License
603 stars 141 forks source link

Drop Node.js v6 support #215

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 5 years ago

The devDependency eslint-plugin-node was updated from 8.0.1 to 9.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

Release Notes for v9.0.0

Update for Node.js v12 🎉

💥 Breaking Changes

✨ New Rules

Commits

The new version differs by 27 commits.

  • a84a009 9.0.0
  • b94731a 💥 no-*-require rules check require.resolve calls as well
  • 528282a 📝 update decuments
  • 9243079 📝 tweak document outline
  • a4fbb9a 📝 update documents
  • ab40a47 📝 update no-extraneous-* document (fixes #148)
  • e41a1e0 ✨ add node/prefer-promises rules (fixes #157, fixes #158)
  • 9143043 ⚒ tweak glob
  • a3e0e29 ✨ add node/file-extension-in-import rule
  • a3a6e41 ⚒ tweak eslint setting
  • 3e4542f ⚒ fix coverage setting
  • d4f104c ⚒ fix travis.yml
  • 0972d6e ⚒ fix test failing
  • 2061413 💥 update node/recommended
  • 9006518 📝 update no-unsupported-features/es-syntax

There are 27 commits in total.

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper bot :palm_tree:

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @greenkeeper[bot], Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 6

View build log

npm test ``` > cloudscraper@4.1.0 test /home/travis/build/codemanki/cloudscraper > npm run lint && nyc --reporter=html --reporter=text mocha > cloudscraper@4.1.0 lint /home/travis/build/codemanki/cloudscraper > eslint --ext .json --ext .js . /home/travis/build/codemanki/cloudscraper/node_modules/eslint-plugin-node/lib/configs/recommended-module.js:7 ...commonGlobals, ^^^ SyntaxError: Unexpected token ... at createScript (vm.js:56:10) at Object.runInThisContext (vm.js:97:10) at Module._compile (module.js:549:28) at Object.Module._extensions..js (module.js:586:10) at Module.load (module.js:494:32) at tryModuleLoad (module.js:453:12) at Function.Module._load (module.js:445:3) at Module.require (module.js:504:17) at require (internal/module.js:20:19) at Object. (/home/travis/build/codemanki/cloudscraper/node_modules/eslint-plugin-node/lib/index.js:6:31) npm ERR! Linux 4.4.0-101-generic npm ERR! argv "/home/travis/.nvm/versions/node/v6.17.1/bin/node" "/home/travis/.nvm/versions/node/v6.17.1/bin/npm" "run" "lint" npm ERR! node v6.17.1 npm ERR! npm v3.10.10 npm ERR! code ELIFECYCLE npm ERR! cloudscraper@4.1.0 lint: `eslint --ext .json --ext .js .` npm ERR! Exit status 2 npm ERR! npm ERR! Failed at the cloudscraper@4.1.0 lint script 'eslint --ext .json --ext .js .'. npm ERR! Make sure you have the latest version of node.js and npm installed. npm ERR! If you do, this is most likely a problem with the cloudscraper package, npm ERR! not with npm itself. npm ERR! Tell the author that this fails on your system: npm ERR! eslint --ext .json --ext .js . npm ERR! You can get information on how to open an issue for this project with: npm ERR! npm bugs cloudscraper npm ERR! Or if that isn't available, you can get their info via: npm ERR! npm owner ls cloudscraper npm ERR! There is likely additional logging output above. npm ERR! Please include the following file with any support request: npm ERR! /home/travis/build/codemanki/cloudscraper/npm-debug.log npm ERR! Test failed. See above for more details. ```
TravisBuddy Request Identifier: a6a33150-6fd9-11e9-91fe-d9d12b7facfa
greenkeeper[bot] commented 5 years ago

Update to this version instead 🚀

Commits

The new version differs by 3 commits.

  • bc02c52 9.0.1
  • dfb4dc0 🐛 fix file-extension-in-import for scoped packages (fixes #160)
  • 11d2d41 📝 tweak documents

See the full diff

ghost commented 5 years ago

@codemanki Node.js v6 reached it's end of life on 2019-04-30, you can read about that here: https://github.com/nodejs/Release

I think should we follow suit and drop support for Node.js v6 that way we don't miss out on any new eslint and ES language features that are supported by Node.js v7.

If you're down with that, is it okay that I push the required changes to this greenkeeper branch?

codemanki commented 5 years ago

@pro-src if you feel that this is good to have - then yes. I still use node v4 in some of my projects tho :(

ghost commented 5 years ago

@codemanki That's unfortunate, AFAIK, you won't receive any support for Node.js versions prior to v7 now. Is there no way for you to update it? The code that runs on v4 should still work on v7 and later with very few exceptions.

I think that everybody should update for security reasons and there often isn't a very good reason not to update. That said, I think we do have something to gain here so I'll push the necessary changes for you to review and for you to make the final decision on whether or not to merge this branch.

codemanki commented 5 years ago

Is there no way for you to update it?

That was just more of a sad side-comment about state of the art of my personal projects :D

Sure, let's then cut off v6.

ghost commented 5 years ago

Oops... I overlooked the fact that v7 and v9 have reached End-Of-Life as well. v8, v10, v11, v12, and later are what we should be supporting.

ghost commented 5 years ago

github com_nodejs_Release

codemanki commented 5 years ago

Thank you!