search

codeminders / socket.io-server-java

Java Backend for Socket.IO (http://socket.io/)
36 stars 18 forks source link

add timeout to the call that gets first EngineIOPacket in XHRTranspor… #10

Closed vkurland closed 6 years ago

vkurland commented 6 years ago

…tConnection.handle() and set version to 1.0.2-b

basically replaced take() with poll() with timeout. I think 3 min is excessive, but leave it up to you to decide. I do not have a clear understanding of how do we end up in the situation where the client has already closed connection by the time of the call to take() is made, so the socket is in CLOSE_WAIT state and take() never returns. See my emails for more detailed analysis.

alexsaveliev commented 6 years ago

I renamed a branch so your PR was closed, sorry. Your changes were merged into v1_0_2_fixes and master, @birdowl will publish new artifacts soon

Thanks!