Webkit: Zero-width characters present if textWrapping=false

codemirror / CodeMirror-v1

An editable-iframe based code editor in JavaScript. See https://github.com/marijnh/CodeMirror for the currently maintained version

http://codemirror.net/

Other

362 stars 63 forks source link

Webkit: Zero-width characters present if textWrapping=false #25

Closed willmoffat closed 14 years ago

willmoffat commented 14 years ago

\u200b chars are not removed if textWrapping is false.

To reproduce:

visit http://codemirror.net/jstest.html
run this JS in the console: editor.mirror.setTextWrapping(false); /\u200b/.test(editor.mirror.getCode()) // --> false
Move the cursor to the end of a line
Press Enter /\u200b/.test(editor.mirror.getCode()) // --> true

These chars break indentation.

mzero commented 14 years ago

Aha - this may be the same issue I was seeing as reported in the google group. I also had testWrapping set to false.

marijnh commented 14 years ago

Hey Will,

Yeah this is an unintended side effect of my workaround for https://bugs.webkit.org/show_bug.cgi?id=47806 . Now, thank me, for I just spent at least three hours blindly experimenting to find another workaround. I pushed something ( 3798a6598c2f7190aa2751b494871b27137c50ac ) that seems to do the trick. If things continue this way, it'll soon be more efficient to dive into the webkit code and fix their bugs for them, rather than work around stuff on our side.

So long, Marijn

willmoffat commented 14 years ago

Hi Marijn, thanks for looking at this. Unfortunately now I'm seeing https://bugs.webkit.org/show_bug.cgi?id=23474 again, but only on my site, not in your demos. Investigating further...