CSS grid units like `fr` are marked as invalid CSS code

codemirror / codemirror5

In-browser code editor (version 5, legacy)

http://codemirror.net/5/

MIT License

26.83k stars 4.97k forks source link

CSS grid units like `fr` are marked as invalid CSS code #5720

Open eduard-ungureanu opened 5 years ago

eduard-ungureanu commented 5 years ago

Whenever using a perfectly valid CSS unit like 1fr the CSS code is marked as being invalid.

For example using something like:

.selector {
display: grid;
grid-tempalte-columns: repeat(2, 1fr);
}

Will always mark the grid-tempalte-columns: repeat(2, 1fr); as being invalid CSS. However, if I change 1fr with 100% everything goes back to normal.

marijnh commented 5 years ago

We don't have anyone following the standard closely, so yeah, it's possible that things are forgotten. This is the first time I hear of the fr unit. You 'units like fr' — are there others that we should add?

eduard-ungureanu commented 4 years ago

@marijnh So sorry for the huge delay, almost 2 years, I simply forgot about this ticket.

Please add all the Support for the CSS Grid, the 1fr unit is a unit added by CSS Grid. There is also no support for using CSS variable names: