search

codemirror / dev

Development repository for the CodeMirror editor project
https://codemirror.net/
Other
5.94k stars 377 forks source link

pressing Enter after typing Korean text inserts duplicate line break [ safari ] #1403

Open SeonJun-Hwang opened 4 months ago

SeonJun-Hwang commented 4 months ago

Describe the issue

In Safari, pressing Enter after typing Korean text results in duplicate line breaks. Please refer to the attached video for more details.

https://github.com/codemirror/dev/assets/38457114/25f9cfac-63ee-4921-b1b3-76610ac87dfa

Browser and platform

safari, mac 10.15

Reproduction link

No response

marijnh commented 4 months ago

Which Korean keyboard setting are you using? I tried a bunch, but none of them behave like what your video is showing, and I couldn't reproduce the issue.

SeonJun-Hwang commented 4 months ago

@marijnh im using the default korean keyboard provided by macOS ( 두벌식, 2-Set ) image image

marijnh commented 4 months ago

Strange. When I type with the Korean - 2-Set keyboard, I never see the composition underline that is visible on your screencast. And Enter doesn't produce this double line break effect. Could you tell me precisely which keys you're pressing? I tried a lot of different ones, but maybe it's some combination I'm not using.

SeonJun-Hwang commented 4 months ago

I pressed just "ㅁ" (on eng Key 'a') and "Enter", "Enter" was pressed when composition underline at "ㅁ"

Upon further inspection, sometimes the composition underline did not appear. However, most of the time the composition underline did appear. After refreshing the page or cross-checking in Chrome, the issue reoccurred.

marijnh commented 4 months ago

I never get the underline in Safari. I always get it in Chrome, but there the issue doesn't appear to occur.

SeonJun-Hwang commented 4 months ago

🤔 It seems that a keyboard supporting Korean or some other settings might be necessary. Thank you for looking into this. 🙏