search

codemirror / dev

Development repository for the CodeMirror editor project
https://codemirror.net/
Other
5.96k stars 377 forks source link

LanguageTool and Grammarly cannot apply suggestions in Chrome #1416

Closed reknih closed 3 months ago

reknih commented 3 months ago

Describe the issue

When editing text in CodeMirror, suggestions from LanguageTool and Grammarly Chrome extensions are shown but cannot be applied. This regression coincided with the use of EditContext, when using @codemirror/view:6.28.1 the bug does not appear. Firefox and Safari are unaffected.

https://github.com/user-attachments/assets/97a1ae94-1ea8-4c0b-83fa-919be4070881

Browser and platform

Google Chrome 126.0.6478.183 (arm64), macOS 14.5

Reproduction link

https://codemirror.net/try/?c=aW1wb3J0IHtiYXNpY1NldHVwLCBFZGl0b3JWaWV3fSBmcm9tICJjb2RlbWlycm9yIgppbXBvcnQge2phdmFzY3JpcHR9IGZyb20gIkBjb2RlbWlycm9yL2xhbmctamF2YXNjcmlwdCIKCm5ldyBFZGl0b3JWaWV3KHsKICBkb2M6IGAjaW1wb3J0ICJAcHJldmlldy9hcHByZWNpYXRlZC1sZXR0ZXI6MC4xLjAiOiBsZXR0ZXIKCiNzaG93OiBsZXR0ZXIud2l0aCgKICBzZW5kZXI6IFsKICAgIEphbmUgU21pdGgsIFVuaXZlcnNhbCBFeHBvcnRzLCAxIEhlYXZ5IFBsYXphLCBNb3JyaXN0b3duLCBOSiAwNzk2NAogIF0sCiAgcmVjaXBpZW50OiBbCiAgICBNci4gSm9obiBEb2UgXAogICAgQWNtZSBDb3JwLiBcCiAgICAxMjMgR2xlbm53b29kIEF2ZSBcCiAgICBRdWFydG8gQ3JlZWssIFZBIDIyNDM4CiAgXSwKICBkYXRlOiBbTW9ycmlzdG93biwgSnVuZSA5dGgsIDIwMjNdLAogIHN1YmplY3Q6IFtSZXZpc2lvbiBvZiBvdXIgUHJvZHVjcmVtZW50IENvbnRyYWN0XSwKICBuYW1lOiBbSmFuZSBTbWl0aCBcIFJlZ2lvbmFsIERpcmVjdG9yXSwKKQoKRGVhciBKb2UsCmAsCiAgZXh0ZW5zaW9uczogW2Jhc2ljU2V0dXBdLAogIHBhcmVudDogZG9jdW1lbnQuYm9keQp9KQo=

marijnh commented 3 months ago

The way code injected via browser extensions interacts with the library is outside of the scope of things that I am willing to take responsibility for. I'd recommend filing an issue with Grammarly.

reknih commented 3 months ago

I have created a forum post on LanguageTool and filed a support ticket with Grammarly.