search

codemirror / dev

Development repository for the CodeMirror editor project
https://codemirror.net/
Other
5.95k stars 377 forks source link

@codemirror/lang-sql: add SparkSQL dialect #1438

Closed it1shka closed 2 months ago

it1shka commented 2 months ago

Describe the issue

Afaik for now there is only one way we can use SparkSQL with CM6: StreamParser + legacy sparkSQL mode. The problem is that this legacy mode has only the highlighting, without any support for autocompletion. I think it would be nice to have SparkSQL included as a dialect into @codemirror/lang-sql

Browser and platform

No response

Reproduction link

No response

marijnh commented 2 months ago

Afaik for now there is only one way we can use SparkSQL with CM6

You could also just do something like this. I am not too keen on keeping dialects for every obscure SQL variant in the main package, but defining them locally is easy enough.

it1shka commented 2 months ago

Ok, thank you so much!