codemirror / dev

Development repository for the CodeMirror editor project

https://codemirror.net/

Other

5.94k stars 376 forks source link

Android: Regression: Missing "select all" in context menu #1451

Open personalizedrefrigerator opened 1 month ago

personalizedrefrigerator commented 1 month ago

Describe the issue

Summary

In Android, the "select all" long-press menu option is missing.

Current behavior (codemirror/view v6.34.1)

select-all-broken.webm

Previous behavior (codemirror/view v6.27.0, codemirror/autocomplete v6.13.0

select-all-working.webm

To reproduce

Run the "Minimal editor" example.
Move the cursor to after the "...".
Type text and select it.
Observe that "select all" is not present in the context menu.
Repeat steps 3-4 for the "code" tab.

Notes

After switching to a working version of @codemirror/view, refreshing the page doesn't seem to be enough to get "select all" to work. Instead, it seems to be necessary to open the demo page in a new tab.
A git bisect suggests that this issue was introduced with 51d20b6bde168685f303e5993d79e396b4873f65.

Browser and platform

Android 13; Chrome Android 128.0.6613.148

Reproduction link

https://codemirror.net/try/

marijnh commented 1 month ago

Chrome appears to disable this menu item when the EditContext API is used. This doesn't seem like reasonable behavior, so I've opened issue 371791303 to report it.