search

codemirror / dev

Development repository for the CodeMirror editor project
https://codemirror.net/
Other
5.94k stars 376 forks source link

@codemirror/autocomplete ^6.18.0 version cm-completionInfo child style broken #1453

Closed AlexErnsberger closed 1 month ago

AlexErnsberger commented 1 month ago

Describe the issue

When custom the autocompletion.Return the DIY Completion.info dom. The dom style was broken. It looks like every element has a default height but I can't find who set it.

Browser and platform

No response

Reproduction link

No response

AlexErnsberger commented 1 month ago

^6.17.0 look like

image
AlexErnsberger commented 1 month ago

^6.18.0 look like

image
marijnh commented 1 month ago

See https://github.com/codemirror/autocomplete/commit/5392819bf4869cfb22de438432eb60c7ebe96e4a . Either make sure you don't have extra line breaks in your HTML/DOM, or override that style with a custom theme. This isn't going to be reverted.

AlexErnsberger commented 1 month ago

Thanks for reply