search

codemirror / lang-example

Example/template repository for building a language package
MIT License
67 stars 41 forks source link

build script #13

Closed StoneCypher closed 2 years ago

StoneCypher commented 2 years ago

Idiomatically and for CI, node modules should have an npm build which does the thing, because your users and all users are Bolin and don't read instructions, and don't know what to do

I know, nobody watches Korra and that metaphor definitely won't make sense

Users want to just npm run build and have it go vroom before they understand, so they can make sure it works (you know, does the, the, does the thing)

Submitting fix PR

marijnh commented 2 years ago

There's all kinds of users, I guess, but the code will already have been built by the prepare script on install, so I don't really see this as a necessary addition.