search

codemix / babel-plugin-typecheck

Static and runtime type checking for JavaScript in the form of a Babel plugin.
MIT License
886 stars 44 forks source link

Type annotations in source are out of date #23

Closed fixplz closed 8 years ago

fixplz commented 8 years ago

What is the status with the type annotations in the type checker's source?

Self-type-checking is currently disabled and enabling it makes the code fail to run, mainly because Babel no longer exposes the Scope type.

I propose we change the package scripts to this and fix the problems, so the annotations stay functional:

"scripts": {
  "build": "babel -d ./lib ./src",
  "build-typed": "babel --plugins typecheck -d ./lib ./src",
  "prepublish": "npm run build",
  "pretest": "npm run build-typed",
  "test": "mocha",
  "watch": "mocha --watch"
},
phpnode commented 8 years ago

Sounds good to me. There used to be a babel issue which prevented this from working but it looks like it's fixed now, would really appreciate a PR :)

phpnode commented 8 years ago

closed via #24