search

codemix / babel-plugin-typecheck

Static and runtime type checking for JavaScript in the form of a Babel plugin.
MIT License
886 stars 44 forks source link

generateUidBasedOnNode has been renamed to generateUidIdentifierBased #9

Closed dzannotti closed 9 years ago

dzannotti commented 9 years ago

generateUidBasedOnNode has been renamed to generateUidIdentifierBased

this PR addresses issue where would trigger calling undefined functions

phpnode commented 9 years ago

@dzannotti thanks for this, but I see that some other tests are broken using the latest version of Babel, will merge this manually when I get chance to fix the other errors (should just be a day or two)

phpnode commented 9 years ago

unless of course you fancy tackling those too? :)

dzannotti commented 9 years ago

The main problem i'm getting atm is what @RickWong reported, which is not strictly related to classes but to other babel changes i think (cannot call .kind of undefined), not investigated that issue at all yet

dzannotti commented 9 years ago

spoke with @sebmck about this, the other error was caused by you using private api, and a bug in babel which has been fixed on this commit https://github.com/babel/babel/commit/45b0d63d7272e0a51c271acaeb5f7c6403cbb778

phpnode commented 9 years ago

Fixed separately now, thanks!