Closed eps1lon closed 3 years ago
Okay, something must have thrown off semantic-release, I'll see if I can sort this out and upgrade ast-types as well.
Actually I'm confused what you mean, I see 2.0.0 on npm via the website and npm view jscodeshift-find-imports version
...maybe there was some wacky npm glitch?
Maybe I confused it with jscodeshift-add-imports
. The issue about ast-types
remains. jscodeshift
is currently multiple versions behind in jscodeshift-find-imports
I think what you meant is that jscodeshift-add-imports
wasn't using version 2 of jscodeshift-find-imports
. I released new versions of both though with jscodeshift
0.11.0 (really wish people would stop using version 0...). Can you upgrade and confirm that everything is fixed for you? You should get ast-types@0.12.1
now.
Btw sometimes with yarn at least to ensure I get the latest version of a transitive dep, I have to remove the primary deps and then add them back, yarn upgrade --latest
doesn't always upgrade the transitive deps.
argh hang on, I accidentally published jscodeshift-find-imports
with @types/jscodeshift
as a dev dep
Actually I think ast-types
should be 0.14.1
if all the transitive deps work correctly, but I'm running into this issue: https://github.com/benjamn/ast-types/issues/425
Do you know if ast-types@0.13.4
will work for you?
In 0.x any minor bump is considered breaking so package managers won't pull in 0.11 if you declare ^0.6
. You have to declare ^0.11
. So removing the lockfile entries wouldn't have done anything here.
While I don't think you should ever use >=
it should fix my specific problem. Will check back tomorrow.
I guess I should use ^0.7.0 || ^0.8.0 || ...
. 0.x packages are so inconvenient to work with...I was worried if I left jscodeshift
as a primary dependency it might cause other issues?
I did that in jscodeshift-add-imports
for 0.7.x up to 0.10.x since it breaks with jscodeshift 0.11.0.
Can't tell if the following releases actually contain breaking changes or not:
Changelogs are virtually guaranteed to be low quality if you're not using some kind of automation like semantic-release
...
forgot to close this
2.0.0 was released on GitHub but npm doesn't include it.
/cc @jedwards1211 When
jscodeshift-find-imports
is released on npm can we at the same time updatejscodeshift-add-imports
.Right now
jscodeshift-add-imports
pulls in an older version ofast-types
that I'd like to get rid of.