Closed lucaswerkmeister closed 10 years ago
Yes you are right. We have to shorten some names because of the max. length of a tweet. In this step we will integrate the right article into the name. That's the simplest solution without changing the root project.
Fixed in 60729cc. Thanks!
This tweet is grammatically incorrect:
should be “…der Physikalisch-Technischen Bundesanstalt”.
I was about to submit a PR to fix this when I noticed that we can’t fix this in
bund-networks.json
because the “des” (male genitive definite article) isn’t part of the names in there – it seems to be hard-coded into a part of the bot’s configuration that’s not part of this repository.I’m not sure how this should be solved. We could move the “des” into the
bund-networks.json
names – the template would then beArtikel ${title} wurde anonym aus dem Netz ${network} bearbeitet\n${link}
(pseudosyntax). We could also somehow add the gender to the JSON, and default it to “male” – advantage: Existing entries mostly don’t need to be changed.