search

codemonauts / bundesedit

Netzwerklisten der Twitterbots euroedit, bundesedit,politikedits und landesedit
http://bundesedit.de/
31 stars 6 forks source link

Physikalisch-Technische Bundesanstalt #2

Closed lucaswerkmeister closed 10 years ago

lucaswerkmeister commented 10 years ago

This tweet is grammatically incorrect:

Artikel "Diemarden" wurde anonym aus dem Netz des Physikalisch-Technische Bundesanstalt bearbeitet

should be “…der Physikalisch-Technischen Bundesanstalt”.

I was about to submit a PR to fix this when I noticed that we can’t fix this in bund-networks.json because the “des” (male genitive definite article) isn’t part of the names in there – it seems to be hard-coded into a part of the bot’s configuration that’s not part of this repository.

I’m not sure how this should be solved. We could move the “des” into the bund-networks.json names – the template would then be Artikel ${title} wurde anonym aus dem Netz ${network} bearbeitet\n${link} (pseudosyntax). We could also somehow add the gender to the JSON, and default it to “male” – advantage: Existing entries mostly don’t need to be changed.

kringkaste commented 10 years ago

Yes you are right. We have to shorten some names because of the max. length of a tweet. In this step we will integrate the right article into the name. That's the simplest solution without changing the root project.

lucaswerkmeister commented 10 years ago

Fixed in 60729cc. Thanks!