search

codemonauts / craft-redactor-nofollow

Craft CMS plugin to expand the Redactor's link module with nofollow relationship attribute.
MIT License
3 stars 1 forks source link

Critical bug - If Open in new Tab is selected, nofollow gets automatically selected #2

Closed jonlongnecker closed 4 years ago

jonlongnecker commented 4 years ago

When using this plugin, nofollow gets automatically selected if "open in new tab" is selected. In this screenshot, I've only selected "open new tab", but after saving if I go back to edit, both items are selected.

This is a pretty big issue as there are plenty of times I'd like to open a link a new tab, but make sure it follows the link. But more importantly, it's specifically doing something I'm telling it not to do (re-selecting the option on save).

Craft CMS 3.4.10.1

fleaz commented 4 years ago

Critical Bug in no-follow Plugin

kringkaste commented 4 years ago

Hi @jonlongnecker thanks for reporting. I will investigate this.

jonlongnecker commented 4 years ago

Hey @kringkaste just checking in here - any luck with this yet?

kringkaste commented 4 years ago

Hey @jonlongnecker, I found the bug and fixed it. When you created a new link and saved the entry, the correct value of the attribute "rel" was saved ("nofollow" set or not set). Only if you edit an existing link the checkbox "nofollow" was always checked when the link also had the target "_blank".

Please update to the release 1.0.1.