codemonkey85 / PKMDS-Blazor

PKMDS: Pokémon Save Editor for Web
https://pkmds.app/
The Unlicense
58 stars 10 forks source link

Pokemon Types shown are off #18

Closed SamsTheNerd closed 2 weeks ago

SamsTheNerd commented 8 months ago
image

types seem to be slightly off. Seems consistent, so all electric types get shown as fighting, fairy as bug, etc.

Also the sprites for pikachu forms are off - they all have hats rather than the "rock star" and "cosplay" forms that are listed on the drop down.

codemonkey85 commented 8 months ago

Thanks, I will look into this.

codemonkey85 commented 8 months ago

@SamsTheNerd For the types - I can't seem to reproduce this. Can you tell me the steps you take to see this issue? It might help if you attach your save file as well (you can zip it and attach it to a comment in this thread).

For the formes - I think I know the issue here, looking at a fix.

SamsTheNerd commented 8 months ago

here's the save file, it's a pokemon X save from the very beginning of the game with the hair color changed: xproperhair.zip

https://github.com/codemonkey85/PKMDS-Blazor/assets/18472542/f849510a-a775-435f-ae99-9541cc56d52c

just tried it with a few other save files and it seems like it's specifically when making a new pokemon and not just editing an existing one. Also it looks like a lot of information is missing when you make a new pokemon vs edit an existing one, atleast on the main screen, like the PID, nature, ability, language, and friendship fields, also the cured, egg, infected, and shiny, checkmarks (also it doesn't seem like the shiny checkmark button works or is even clickable), not sure if that stuff is related ?

codemonkey85 commented 8 months ago

@SamsTheNerd Ah, thanks for the info. Yeah, creating a new Pokémon is a process that needs some work.

codemonkey85 commented 6 months ago

Linking to #24.

codemonkey85 commented 2 weeks ago

At some point I fixed this by setting a default game of origin on a blank slot.