search

codemonkey85 / PKMDS

A Pokémon save hacking library written in C++! (currently supports Gen V and limited portions of Gen III / VI)
The Unlicense
22 stars 5 forks source link

Encounter types being set incorrectly #20

Closed codemonkey85 closed 10 years ago

codemonkey85 commented 10 years ago

Reported by @kwsch.

codemonkey85 commented 10 years ago

11:16 PM yo codemonkey85, I noticed some of your transferred things have encounter type of 0x18 11:17 PM hm it might be rightshifted 1 11:23 PM temp fix is to just regard starter/fossil/gift as actually 24, not 12

codemonkey85 commented 10 years ago

All mentions of encounters in code:

https://github.com/codemonkey85/PKMDS/blob/dev/include/pkmds/pkmds_g5.h#L2319 https://github.com/codemonkey85/PKMDS/blob/dev/include/pkmds/pkmds_g5.h#L3367 https://github.com/codemonkey85/PKMDS/blob/dev/include/pkmds/pkmds_g6.h#L2947 https://github.com/codemonkey85/PKMDS/blob/dev/lib/pkmds_gba.cpp#L1500

codemonkey85 commented 10 years ago

Doesn't look like this is anything caused by my software - probably just a hacked Pokémon sneaked into one of the save files. Closed for now!