codemonkey85 / PKMDS

A Pokémon save hacking library written in C++! (currently supports Gen V and limited portions of Gen III / VI)
The Unlicense
22 stars 5 forks source link

Generational Changes #3

Open codemonkey85 opened 10 years ago

codemonkey85 commented 10 years ago

This is an extension of the issue I opened with the veekun repository - https://github.com/veekun/pokedex/issues/107

ncorgan commented 10 years ago

Unless I'm mistaken, stat changes are also not accounted for. Quite a few earlier Pokemon (Pikachu, for example) had their stats changed in Generation 6, and a couple others throughout. Roselia's stats in Gen 3 were different than 4-6, etc.

codemonkey85 commented 10 years ago

Yes, that is true - although I haven't checked yet to see if those stat changes have been applied to the veekun database. That issue could be solved the same way though, with an extra column in some tables for generation or game version (the solution @magical proposed).

ncorgan commented 10 years ago

The last SQLite binary I downloaded (I believe it was from November 15-ish) had all the Gen 6 stuff and no accounting for stat changes. I'm not sure if it's been updated since then.

On Fri, Jan 3, 2014 at 7:08 AM, Michael Bond notifications@github.comwrote:

Yes, that is true - although I haven't checked yet to see if those stat changes have been applied to the veekun database. That issue could be solved the same way though, with an extra column in some tables for generation or game version.

— Reply to this email directly or view it on GitHubhttps://github.com/codemonkey85/PKMDS/issues/3#issuecomment-31527707 .

Nicholas Corgan

codemonkey85 commented 10 years ago

As a quick fix I have rolled back the veekun-pokedex.sqlite file to an earlier version.