search

codemybrainsout / smart-app-rate

An Android library that encourages users to rate the app on the Google Play.
Apache License 2.0
675 stars 165 forks source link

threshold doesn't work #39

Open asystat opened 6 years ago

asystat commented 6 years ago

Whenever I set the threshold via .threshold(4) for example, the threshold remains at 3.

0xPixelfrost commented 6 years ago

It works for me in version 1.0.8

Your code should look like this: .threshold(4f)

tvaknin commented 4 years ago

I think the issue is that the Stars are not buttons, but Rating Bar. Therefore, It depends where you press along the bar and not on which star. It would be better to change it to buttons.

In the mean time, I found that changing the .threshold(4.1f) will give me <=4 on most cases.

OrhanTozan commented 3 years ago

Like @tvaknin, it looks like a RatingBar issue. The RatingBar see's the middle point of the star as the threshold, instead of the begin. For example, clicking on the first half of the first star gives you a rating of 1.0. Click on the second half of the first star and you get a rating of 2.0. Weird design.