search

codenamecpp / carnage3d

Reimplementation of Grand Theft Auto 1 [GTA1]
MIT License
481 stars 38 forks source link

Improved demo support in the Makefile #17

Closed neuromancer closed 5 years ago

neuromancer commented 5 years ago

This PR allows users to quickly test Carnage3D executing:

$ make
$ make demo
$ make run

The demo will be download from the official Rockstar website, extracted and configured to run.

codenamecpp commented 5 years ago

I think it is actually a good idea.

But I have few complaints: 1) Script will overwrite user's settings file and and he won’t be happy :( I think that new command line param must be added to specify gta1 data location and it will take precedence over the one that comes from config file. 2) The first thing I think about when see the word 'demo' is game demonstration record. I thing it will be better rename to 'demoversion' So, instead of 'demo' command I would like to see 'get_demoversion'. 'run' should be left as it was and add new command 'run_demoversion'.

I will put gamedata/demoversions directory to git ignore. All demos can be put there.

codenamecpp commented 5 years ago
neuromancer commented 5 years ago

I agree with your remarks. Feel free to edit this PR!

neuromancer commented 5 years ago

It is also useful to reorganize a little the README to put this information somewhere, probably in a Getting started section or something like that.

neuromancer commented 5 years ago

Looks good to me!

codenamecpp commented 5 years ago

OK, done. Thanks.