search

codenamecpp / carnage3d

Reimplementation of Grand Theft Auto 1 [GTA1]
MIT License
470 stars 38 forks source link

Update Box2D to version 2.4.1 #67

Closed marmichalski closed 2 years ago

marmichalski commented 2 years ago

This should be fine, but would be great if someone could run the premake build. I am creating a cmake build env and that's where I have tested these changes. There is quite a few whitelines changes in touched files, I did not try to resolve them in any way, as unified line endings are my preference :P

Edit: or actually I probably forgot to update premake. I'll update in a few.

Done. It compiles & runs. I have not updated the Visual Studio project as I have no way to test the changes - maybe just updating the files list should be enough :thinking:

image

codenamecpp commented 2 years ago

Oh, I didn't expect that. Nice work, thanks, @marmichalski !

As for 'static_cast' over 'c-style' cast, I haven't decided yet what I prefer more, usually I'm too lazy to write ***_cast<> etc but in general, I don't mind.

marmichalski commented 2 years ago

Oh, I didn't expect that. Nice work, thanks, @marmichalski !

As for 'static_cast' over 'c-style' cast, I haven't decided yet what I prefer more, usually I'm too lazy to write ***_cast<> etc but in general, I don't mind.

Hey, no problem. I have updated the visual studio project for box2d, the src dir is needed in the additional include paths because there is, I believe, not correctly included file in one of the source files. I will open up a PR in Box2D and see what they think - if it will be accepted, the additional include path could be removed, if not, will have to stay with us :P

I am not updating the casts, because I see no reason to. I can do that, if that's what you prefer, @codenamecpp, but I see you don't mind too :)

Edit: Said box2d PR - https://github.com/erincatto/box2d/pull/702